Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong and missing color values in budget levels reference file #7

Open
epicallan opened this issue Jul 5, 2017 · 5 comments
Open

Comments

@epicallan
Copy link
Contributor

No description provided.

@dw8547
Copy link
Collaborator

dw8547 commented Jul 7, 2017

@epicallan, which reference file? (I.e., do you have a link to the file in the digital-platform repo? Might be able to help.

@epicallan
Copy link
Contributor Author

@dw8547
Copy link
Collaborator

dw8547 commented Jul 7, 2017

Hi @epicallan, here is the info I have got so far:

What is domestic-budget-level.csv for?

domestic-budget-level.csv is a reference file for domestic.csv.

Originally, there were special characters in the level names in domestic-budget-level.csv that couldn't be used as HTML element ids (needed to run the visual). So this file was a mapping between the sluggified (special characters and spaces replaced with dashes) names and the original names.

What is the workflow here?

"Go to domestic.csv, draw the boxes using the level ids in domestic.csv, look-up an "un-sluggified" version of id in domestic-budget-level.csv to draw human-readable name on top of box."

And what do I do if the colour is missing from domestic-budget-level?

"The visual has some sort of default colour???"

@epicallan
Copy link
Contributor Author

epicallan commented Jul 7, 2017

Hi @dw8547

Thanks for looking into this. What I want is for us to use colours from domestic-budget-level.csv instead of hard coded defaults ones within the app. I would prefer if we went a head and added the correct colour values in domestic-budget-level.csv at some point in the future.

@dw8547
Copy link
Collaborator

dw8547 commented Jul 10, 2017

@epicallan, not a problem. Let me know when you are ready to do this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants