Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Volume Handling #6

Open
mitschwimmer opened this issue Apr 25, 2021 · 2 comments
Open

Implement Volume Handling #6

mitschwimmer opened this issue Apr 25, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@mitschwimmer
Copy link
Collaborator

Let me begin with a question. The sink API defines a method ".setVolume()". Should this method be implented in such a way that it:

  1. actually controlls the media volume of the device
  2. controls the gain level of the current track. It would default to "1.0" which means flat, unchanged gain
  3. does nothing on Android as most users of this lib would use an "android-idiomatic" way of manipulating volume

I think the third option makes sense. @devgianlu what do you think?

@devgianlu
Copy link
Owner

On the "desktop" version it controls the line volume directly. Which in Android would be the equivalent of modifying the device volume, but I do not like this idea. I think the best solution is to have double volume control (Linux has master and line volumes):

  • if the volume change event comes from the device it should be a no-op for the library
  • if the volume change event comes from the Spotify API, change the internal volume of the sink.

We should probably have a look at what the original client for Android does.

@mitschwimmer mitschwimmer added the enhancement New feature or request label Jan 8, 2022
@iscle
Copy link

iscle commented Feb 7, 2022

We should probably have a look at what the original client for Android does.

Adding to this old issue, the original Android client does not modify the volume in any way. If you use Spotify Connect from another device, you can't modify the volume of the Android client. This is something I've always thought would be nice to have, and for me, the best way would be modifying the device's volume directly (but only if Spotify is playing).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants