Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom package name & version for the generated sdk #114

Open
volkyeth opened this issue Oct 21, 2022 · 1 comment
Open

Allow custom package name & version for the generated sdk #114

volkyeth opened this issue Oct 21, 2022 · 1 comment

Comments

@volkyeth
Copy link

volkyeth commented Oct 21, 2022

As Originally reported by @johanneskares in #102 (comment), the generated package is not compatible with yarn workspaces:

Now I can include it as depdendency in my monorepo. Only problem is, I manually have to change the name of the generated package, because yarn doesn't like the name of the package .dethcrypto/eth-sdk-client in package.json. When I do

yarn workspace my-package add .dethcrypto/eth-sdk-client

I get Usage Error: The .dethcrypto/eth-sdk-client string didn't match the required format (package-name@range). Did you perhaps forget to explicitly reference the package name?

When I manually edit it to dethcrypto-eth-sdk-client-generated, everything works fine.

Customizing the generated package name in the config would solve this.
Also, to use it as a standalone package in a monorepo setup - which is great if you're going to use the sdk in both the backend and front-end - it needs a version, which could either be included as a static field in the configuration, or initialized to a configurable value and then dynamically incremented in subsequent updates

The way it works today, I have to rewrite the sdk's package.json every time I update it

@johanneskares
Copy link

I switched over to using wagmi's getContract. You can just commit the json ABI and don't need a separate generation step.

wevm/abitype#48 (reply in thread)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants