Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move JTC action server and trajectory sampling into separate class #32

Open
wants to merge 1 commit into
base: ros2-controllers-extensions4
Choose a base branch
from

Conversation

nbbrooks
Copy link
Collaborator

Add new file trajectory_execution_impl.hpp, which is responsible for:

  • setting up and managing a control_msgs::action::FollowJointTrajectory action server
  • checking/managing the current Trajectory
  • in general, any sort of manipulation/validation of JointTrajectory messages

The idea is to pull out this common functionality from JointTrajectoryController so that it can be easily repurposed in other controllers want to handle JointTrajectory messages.

For future thought, we could potentially add new functions or comments to ControllerInterface to make it more clear the typical steps done in the update() function.

@nbbrooks nbbrooks requested a review from destogl September 24, 2021 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant