Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typ defs missing for commons.color #4604

Open
1 task done
vincerubinetti opened this issue Oct 10, 2024 · 1 comment
Open
1 task done

Typ defs missing for commons.color #4604

vincerubinetti opened this issue Oct 10, 2024 · 1 comment
Labels
feat New feature or enhancement typescript TypeScript issues

Comments

@vincerubinetti
Copy link

Product

axe-core

Product Version

4.10.0

Latest Version

  • I have tested the issue with the latest version of the product

Issue Description

Screenshot 2024-10-10 at 11 20 53 AM

https://github.com/search?q=repo%3Adequelabs%2Faxe-core%20getBackgroundColor&type=code

https://github.com/search?q=repo%3Adequelabs%2Faxe-core+commons&type=code

I've run into other incorrect/missing typings too but unfortunately can't remember them. I'd strongly recommend a repo-wide audit for types.

@vincerubinetti vincerubinetti added the ungroomed Ticket needs a maintainer to prioritize and label label Oct 10, 2024
@WilcoFiers
Copy link
Contributor

Axe core commons are not considered part of the public API of axe-core. Some of them are typed because people have found typing them useful, but most of them are not. Feel free to open a pull request if you wish to have types for these.

@WilcoFiers WilcoFiers added feat New feature or enhancement typescript TypeScript issues and removed ungroomed Ticket needs a maintainer to prioritize and label labels Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or enhancement typescript TypeScript issues
Projects
None yet
Development

No branches or pull requests

2 participants