Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/#230 QA 수정 #234

Merged
merged 4 commits into from
Feb 3, 2024
Merged

Feat/#230 QA 수정 #234

merged 4 commits into from
Feb 3, 2024

Conversation

YelynnOh
Copy link
Collaborator

@YelynnOh YelynnOh commented Feb 2, 2024

PR의 목적을 알려주세요.

close #230

어떤 변경사항이 있는지 알려주세요.

  • 지도에서 보이는 핀을 수정했습니다. 피그마랑 살짝 다른 부분이 있어서 수정했어요!
  • IOS 앱 이슈로 우선 온보딩 화면에서 사용했던 video를 gif로 변경했습니다. 넘겨 받은 gif 파일이 애초에 무한 루프를 돌고 있어서 실행하면 온보딩 화면에서 무한 반복으로 애니메이션이 재생되고 있습니다.... ㅎㅎㅎ 디팀 컨펌 받고 추후 고치는 걸로 하기로 했습니다!

중점적으로 봐주었으면 하는 부분

@YelynnOh YelynnOh added the fix Fix something was not working label Feb 2, 2024
@YelynnOh YelynnOh self-assigned this Feb 2, 2024
@YelynnOh YelynnOh merged commit 5e9d5b9 into main Feb 3, 2024
2 checks passed
@YelynnOh YelynnOh deleted the feat/#230 branch February 3, 2024 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Fix something was not working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

QA - 핀, 온보딩 높이, 온보딩 gif 변환
1 participant