-
-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make skipTestGroups resolution logic configurable #270
Comments
I imagine you could achieve this already by using something like the below in your configuration rather than relying on the special opinionated dependencyCheck {
skipConfigurations = configurations.findAll { it.name ==~ /(?i).*test.*/ }.collect { it.name }
} |
A customizable And so all the configurations in hierarchy will not match |
I don’t really understand why you can’t do whatever you like using an example like I gave above to dynamically populate skipConfigurations? Essentially that fragment is a customisable isTestConfiguration, no - write the equivalent in Kotlin? |
Yes, you are totally right. I didn't get this dynamic approach the first time I read it. And due to the fact that the ticket is still open, I did my post. After reading #22, i understood your nice one liner. Maybe both of these should not be open anymore? |
resolved with comment #22 (comment). Leaving #22 open for now as documentation - until I get a chance to update the official documentation. |
Currently
skipTestGroups
operates on the implicit prefixes oftest
andandroidTest
(the other explicit matches don't end up mattering since they meet these prefixes).It would be helpful if these prefixes could be configurable so that new test sourceSets of the form
xTest
(ex:integrationTest
,functionalTest
,acceptanceTest
) could be excluded easily from scans.Alternatively having a regex option here would also help (to just be able to exclude anything with
.*Test.*
or.*test.*
) but I understand if that's too large of a change.Would be happy to do the work for this, just looking for the direction you would like to go before starting (I'm guessing an additional extension
ListProperty<String>
that would default totest
,androidTest
.The text was updated successfully, but these errors were encountered: