Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependabot rebase jumped the tracks #7919

Open
1 task done
dkfellows opened this issue Aug 29, 2023 · 2 comments
Open
1 task done

dependabot rebase jumped the tracks #7919

dkfellows opened this issue Aug 29, 2023 · 2 comments
Labels
T: bug 🐞 Something isn't working

Comments

@dkfellows
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Package ecosystem

Maven

Package manager version

No response

Language version

Java 11, 14, 17

Manifest location and content before the Dependabot update

Project: https://github.com/SpiNNakerManchester/JavaSpiNNaker
Manifest: /pom.xml

dependabot.yml content

https://github.com/SpiNNakerManchester/JavaSpiNNaker/blob/master/.github/dependabot.yml

Updated dependency

Spring Boot, 2.7.14 → 2.7.15 / 3.1.3

What you expected to see, versus what you actually saw

Dependabot submitted a PR to update Spring Boot from 2.7.14 to 2.7.15. Due to other things going on (permission issue), the PR failed to build automatically along with multiple others submitted at the same time. I fixed that problem and told Dependabot to @dependabot rebase to pick up the fix. So far so ordinary.

But the rebased version was no longer a change from 2.7.14 to 2.7.15 but rather to 3.1.3, a different major version with rather a lot of significant changes that made many aspects of the build fail. (I have a branch where this version is in use, but can't update my primary branch to it yet due to messy deployment restrictions.) This is not what I'd expect from a rebase. I would expect something more like a classic git rebase.

It was easy to work around once I saw what it'd unexpectedly done, but very much not as expected.

Native package manager behavior

No response

Images of the diff or a link to the PR, issue, or logs

Smallest manifest that reproduces the issue

No response

@dkfellows dkfellows added the T: bug 🐞 Something isn't working label Aug 29, 2023
@yeikel
Copy link
Contributor

yeikel commented Sep 9, 2023

Wow, that's quite the bug. Thanks for logging it

Everything about this is wrong, because even the commit is misleading

SpiNNakerManchester/JavaSpiNNaker@aca8a6b

The commit that started it all was SpiNNakerManchester/JavaSpiNNaker@01775a4

As it says Updates org.springframework.boot:spring-boot-starter from 2.7.14 to 2.7.15 when it is updating to 3.1.3

@huehnerlady
Copy link

We run into the same error, what is the update no this? It has been open for months and is quite a severe bug...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T: bug 🐞 Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants