Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicated PR created for a dependency present in just one of several packages in a monorepo #3443

Closed
gnarea opened this issue Apr 5, 2021 · 5 comments
Labels
F: monorepo 📦 Issues related to bumping a dep in manifests from multiple apps L: javascript:npm npm packages via npm T: bug 🐞 Something isn't working

Comments

@gnarea
Copy link

gnarea commented Apr 5, 2021

Package ecosystem

npm

Manifest location and content prior to update

dependabot.yml content

https://github.com/relaycorp/awala-gateway-desktop/blob/master/.dependabot/config.yml

Updated dependency

@relaycorp/relaynet-testing from 1.1.4 to 1.1.5

What you expected to see, versus what you actually saw

@relaycorp/relaynet-testing is only used in /packages/daemon/package.json, not in /package.json, so I expected to see just one PR for this dependency. Instead, I got 2 PRs, and the one for the root package.json doesn't actually change /package.json, but /packages/daemon/package.json -- so the two PRs are identical except for the PR titles.

Images of the diff or a link to the PR, issue or logs

The PR I'd expect: relaycorp/awala-gateway-desktop#64

The additional PR I wouldn't expect: relaycorp/awala-gateway-desktop#63

@gnarea gnarea added the T: bug 🐞 Something isn't working label Apr 5, 2021
@Jericho
Copy link

Jericho commented Mar 19, 2022

This sounds very similar to #1408 which means that this problem is not limited to npm packages.

@gnarea
Copy link
Author

gnarea commented Jun 14, 2022

I don't see this issue in any of the 40+ repos we have, except for the one repo where we use a monorepo. And roughly 50% of our repos use NPM and around 40% Gradle.

gnarea added a commit to relaycorp/awala-gateway-desktop that referenced this issue Jun 14, 2022
@jeffwidman jeffwidman added the L: javascript:npm npm packages via npm label Nov 24, 2022
@jeffwidman
Copy link
Member

jeffwidman commented Feb 7, 2023

Given the path to the dependabot config file mentioned in the original post, that was for Dependabot preview, before the service was rewritten native to GitHub. So the bug/behavior may have changed.

I see on the repo (thankfully it's public) that you're still using Dependabot... Are you still seeing this?

@gnarea
Copy link
Author

gnarea commented Feb 7, 2023

Thanks for looking into this @jeffwidman. I haven't seen this issue in ages so I'll go ahead and close this.

@gnarea gnarea closed this as completed Feb 7, 2023
@jeffwidman
Copy link
Member

That's great news! Thanks for letting us know.

@jeffwidman jeffwidman added the F: monorepo 📦 Issues related to bumping a dep in manifests from multiple apps label Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
F: monorepo 📦 Issues related to bumping a dep in manifests from multiple apps L: javascript:npm npm packages via npm T: bug 🐞 Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants