Update check-parameters automation to fail on AWS errors

[rmtolmach]

partially written by AI

User Story

As a PR reviewer, I want the check-parameters automation to fail when it encounters AWS permission errors, so that invalid parameter validation results are not incorrectly posted to PRs.

Issue Description

The check-parameters automation in the vsp-infra-application-manifests repo validates AWS parameters in a PR by checking their existence in Parameter Store. In https://github.com/department-of-veterans-affairs/vsp-infra-application-manifests/pull/3276, the automation encountered a permission error while attempting to check the /cms/ parameter but still posted a comment to the PR claiming the parameters were valid. See the Query for parameters... section of the action.

This issue highlights a flaw in the automation: it does not fail when the aws ssm get-parameters command returns an error. The automation should halt and report the failure instead of posting potentially incorrect validation results.

Tasks

• Update the check-parameters script to capture errors from the aws ssm get-parameters command.
• Ensure the script fails the workflow if any error is encountered while running the AWS command.
• Test the updated script to ensure it properly fails on permission errors and does not post incorrect comments.

Acceptance Criteria

• The check-parameters automation halts and fails the workflow if it encounters any AWS errors, such as permission issues.
• No incorrect comments about parameter validity are posted to PRs when an error occurs.
• Changes are tested and verified in a development or staging environment.

---

Validation

Assignee to add steps to this section. List the actions that need to be taken to confirm this issue is complete. Include any necessary links or context. State the expected outcome.