Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to R&S design #20002

Open
2 of 12 tasks
davidmpickett opened this issue Dec 2, 2024 · 8 comments
Open
2 of 12 tasks

Updates to R&S design #20002

davidmpickett opened this issue Dec 2, 2024 · 8 comments
Labels
Design CMS team practice area Needs refining Issue status Public Websites Scrum team in the Sitewide crew R&S: Tagging/Searching Resources and support CMS managed product owned by Public Websites team sitewide UX

Comments

@davidmpickett
Copy link
Contributor

davidmpickett commented Dec 2, 2024

Description

Changes needed for Prototype:

  • Mobile layout of Detail page

Changes needed from Midpoint Feedback - not needed for Prototype

  • Must: revisit order of "Show filters" button and "Showing 1 - X of Y results" 98001
  • Must: update the "Showing 1 - X of Y results" message to "Showing 1 - X of Y results for 'term' with 3 filters applied" 98001
  • Must: "Clear all" button must be styled to look like a button 98001

Roles / assignments

  • Engineering review:
  • Design review:
  • Accessibility review:
  • Product acceptance:

Acceptance criteria

ACs should capture expected behavior, to inform test plans. Consider devices, documentation updates including KBs, change management, and content model when applicable.

  • [ ]
  • Impact analysis is filled out and QA test plan is updated accordingly
  • Does this product have an existing regression test plan?
    • Yes, link:
    • No, regression test plan will be created as part of the work / points in this ticket
@aklausmeier
Copy link

Show filter behavior is different on desktop vs mobile, important to include desktop in research

@aklausmeier
Copy link

aklausmeier commented Dec 5, 2024

cc @davidmpickett @thejordanwood @laflannery

Revisions made so far in Figma 🟡 WIP - R3 search filters (revisions):

  • Intro copy revised to include "search or filter" in the first few words so AT users know both options are available. @laflannery to discuss with Bryan on governance to see if this passes. If not, @thejordanwood can explore a design iteration. I started in this Figma frame.
  • Included search term in: Showing 1–4 of 4 results for “appeal”
  • Included # of filters applied in: Showing 1–4 of 4 results for “appeal” with 4 filters applied
  • Clear all button styling to match icon button with minor revisions that will need to be added to experimental design ticket if tests well in research. This button has a white background, lower case for better readability, shares red X icon. The current icon buttons are currently only allowed when paired with a primary link and we do not have that use case.
  • On detail page, updated "Topics" in front of filter chips to "Tags" which is currently used today. We can stick with this OR choose another term that encompasses all.
  • increased size of "X" on chips from experimental design feedback, chip size may have also grown a bit taller when this changed
  • increased spacing between chips so tappable area has a minimum affordance of 40px

@aklausmeier
Copy link

Also left comment on accessibility ticket:

Must: When viewing a details page linked from the results, the filter chips are present again to show the taxonomical labels for the page. But the chips play a different role here when clicked (navigational rather than action), and those differences need to be reflected in both the semantics and the visual presentation. Is there a reason why they couldn't just be ordinary links here?

@briandeconinck This was discussed during the experimental design ticket notes to some extent. It's also how it behaves today. I would prefer these stay consistent in design as filter options. Would love for you and @laflannery to discuss this a bit more. It seems like a grey area to me. It does take them to a new page but clicking on the filter chip in this scenario creates a new search results list like a search button might.

@davidmpickett
Copy link
Contributor Author

Updated the Filter Chip component to 1) fix alignment of label text and X icon 2) make the three version true variants of one base component. I also updated instances of the chip in R3 to use new sub variants where applicable

Image
Image

Image

@davidmpickett davidmpickett self-assigned this Dec 6, 2024
@davidmpickett
Copy link
Contributor Author

@jilladams @FranECross - FYI that while this ticket isn't fully refined, it is technically in progress. In addition to @aklausmeier's work, I am starting to pick away at it. This is one I will be continuing in Sprint 19

@davidmpickett
Copy link
Contributor Author

End of sprint update

  • Moving this back to "To Refine" as we still haven't fully parsed all the midpoint feedback and ensured all necessary changes are accounted for in the ACs of this ticket

@jilladams
Copy link
Contributor

jilladams commented Dec 10, 2024

@davidmpickett @FranECross is the remainder of that refinement work blocked on having Amanda present to discuss? This'll be a topic in UX sync next time? Wondering if we can get it into sprint 19, or if it'll sit til after the convo guide / research plan advance.

@davidmpickett
Copy link
Contributor Author

I don't think we need Amanda to refine it, we have a lot of notes that @FranECross took about Amanda's opinions on various aspects and what we should or shouldn't implement. Mostly this ticket just needs someone who to spend the time parsing what feedback has already been implemented, what feedback we won't be implementing and what's left to implement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Design CMS team practice area Needs refining Issue status Public Websites Scrum team in the Sitewide crew R&S: Tagging/Searching Resources and support CMS managed product owned by Public Websites team sitewide UX
Projects
None yet
Development

No branches or pull requests

3 participants