Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: new mobile app logs 'missing environment sid' #2091

Open
6 tasks
cris-oddball opened this issue Oct 31, 2024 · 0 comments
Open
6 tasks

BUG: new mobile app logs 'missing environment sid' #2091

cris-oddball opened this issue Oct 31, 2024 · 0 comments

Comments

@cris-oddball
Copy link

cris-oddball commented Oct 31, 2024

Description

After working #2019 for Prod missing SID logs, new logs started showing up in the lowers that were previously not present. This does not appear to impact the functionality of the Push notification route (a pass-through at this time). See Additional Information below for more details.

  • Ticket is understood, and QA has been contacted (if the ticket has a QA label).
  • This work is added to the sprint review slide deck (key win bullet point and demo slide)

Steps to Reproduce

  1. Deploy main to an environment
  2. Observe the logs described below

Workaround

We can ignore the logs, since the feature works.

Impact/Urgency

Low, but we should not have logs that indicate problems and then not handle the problem.

Expected Behavior

  • When I deploy to an environment, the missing SID logs should not be present
  • When I send a Push notification, the notification is issued.
  • App that was registered is logged

QA Considerations

  • Check the logs on deployment

Additional Info & Resources

Screenshot of logs
Image

Datadog link to the logs in Perf.

Some considerations based on various Slack convos:

- push works. let's not forget that!

  • Apparently these logs only display during the migration step in the deployment

Screenshot 2024-10-31 at 4.13.20 PM.png

  • Maybe the MobileAppRegistry app is not initializing as intended in the Push notification route.
  • It seems to be the case that the environment variables aren't available when expected .
  • The value is in the s3 bucket, correctly.
  • The "Missing SID for app" log is gone so it's not erroring when it gets to the /_status endpoint or the Push Notifications endpoints.
  • This script is used for every deploy but only on the deploys that do not have the VANOTIFY_SSL_CERT_PATH variable or VANOTIFY_SSL_KEY_PATH variable available hit the log 'bypassing VAProfile cert and key file generation' and then are followed by the 'Missing environment SID' logs.
    DEV yesterday at 3:46 PM
    PERF today at 10:52 AM
    And DEV Today at 12:51PM after I redeployed.
  • The 'bypassing VAProfile cert and key file generation' and the two 'Missing environment SID' logs only appear to happen once per deploy.
  • As far as I can tell - the two features that use the updated MobileAppRegistry class (/_status and /v2/notifications/push) are not impacted by whatever this is. Both appear to be getting the appSIDs as expected (Example - I just sent a PUSH and the sid was included) And they are not initializing the MobileAppRegistry to do so (I check the logs for the Initializing MobileAppRegistry log I added.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants