You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
On 9 OCT 2024, GitHub updated their runners such that ubuntu:latest was upgraded to 24.04.1. This failed to run the unit tests with this error
oscrypto.errors.LibraryNotFoundError: Error detecting the version of libcrypto
To work around this issue, the GH action that runs the tests was modified to pin ubuntu down to ubuntu-22.04 in this Hotfix.
After a brief discussion, the team decided that it would be best to run the unit tests in a container, preferably using Alpine (to match the API docker images). See the QA repo for an example, since those tests run in a container.
Ticket is understood, and QA has been contacted (if the ticket has a QA label).
User Story(ies)
As a VANotify engineer I want to run unit tests in a container when I push my branch So that we can completely control the OS the tests run on and not be at the mercy of a random GH upgrade.
Apparently, the error can also happen when the memory is too low. We could try using a GH Ubuntu runner with more cores (and thus more memory) but the preferred outcome is to be able to fully control the OS the tests run in, which means using a container.
Acceptance Criteria
When I push to my remote branch, the unit tests run (via an action) inside an Alpine container using Poetry, not in the GitHub runner directly.
This work is added to the sprint review slide deck (key win bullet point and demo slide)
QA Considerations
Potential Dependencies
The text was updated successfully, but these errors were encountered:
User Story - Business Need
On 9 OCT 2024, GitHub updated their runners such that ubuntu:latest was upgraded to 24.04.1. This failed to run the unit tests with this error
To work around this issue, the GH action that runs the tests was modified to pin ubuntu down to ubuntu-22.04 in this Hotfix.
After a brief discussion, the team decided that it would be best to run the unit tests in a container, preferably using Alpine (to match the API docker images). See the QA repo for an example, since those tests run in a container.
User Story(ies)
As a VANotify engineer
I want to run unit tests in a container when I push my branch
So that we can completely control the OS the tests run on and not be at the mercy of a random GH upgrade.
Additional Info and Resources
Failed run
Apparently, the error can also happen when the memory is too low. We could try using a GH Ubuntu runner with more cores (and thus more memory) but the preferred outcome is to be able to fully control the OS the tests run in, which means using a container.
Acceptance Criteria
QA Considerations
Potential Dependencies
The text was updated successfully, but these errors were encountered: