Remove old feature flags - SMS_SENDER_RATE_LIMIT_ENABLED

[MackHalliday]

User Story - Business Need

• Ticket is understood, and QA has been contacted (if the ticket has a QA label).

There were old feature flags identified when working on #1711. While reviewing which task definitions to be removed, it was observed that several task definitions were old feature flags that were all set to True or never turned on. These feature flags with their related task definitions, code paths, and tests should be removed. See additional information to see list of feature flags.

The focus on this ticket is specifically to remove the feature flag SMS_SENDER_RATE_LIMIT_ENABLED. It is used in three if statements in the code base.

User Story(ies)

As a VA Notify Developer,
I want remove old SMS_SENDER_RATE_LIMIT_ENABLED feature flag with related code paths and task definitions
So that the code runs efficiently and continues to be maintainable.

Additional Info and Resources

See spreadsheet created for ticket #1711 - filter by 'feature flag removal' under the 'removal status' column
There's the Feature Flags that were identified for removal while working on #1711

Acceptance Criteria

• SMS_SENDER_RATE_LIMIT_ENABLED feature flag with related task definitions, code paths, and tests are removed
• SMS_SENDER_RATE_LIMIT_ENABLED removed from all three if statements
• If there's any updated logic that is not covered by testing, please write tests, tests in DEV and make a note fore QA on new untested logic.
• Test suite and regression test run without fail
• This work is added to the sprint review slide deck (key win bullet point and demo slide)

QA Considerations

• Test any new/untested logic written by developer. Developer to make notes for QA.

Potential Dependencies

[npmartin-oddball]

Hey team! Please add your planning poker estimate with Zenhub @cris-oddball @EvanParish @k-macmillan @MackHalliday @mchlwellman

[kbelikova-oddball]

Please add your planning poker estimate with Zenhub @kalbfled