Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old feature flags - ACCEPT_RECIPIENT_IDENTIFIERS_ENABLED #2015

Open
6 tasks
MackHalliday opened this issue Sep 25, 2024 · 1 comment
Open
6 tasks

Comments

@MackHalliday
Copy link

MackHalliday commented Sep 25, 2024

User Story - Business Need

  • Ticket is understood, and QA has been contacted (if the ticket has a QA label).

The feature flag ACCEPT_RECIPIENT_IDENTIFIERS_ENABLED was identified for removal when working on ticket #1711. This flag, its related task definitions, code paths, and tests should be removed to ensure efficient and maintainable code.

accept_recipient_identifiers_enabled uses this feature flag. The method accept_recipient_identifiers_enabled is used in the code paths to POST notifications objects. Please be mindful of branching code paths when removing this feature flag and related method accept_recipient_identifiers_enabled.

User Story(ies)

As a VA Notify Developer,
I want to remove the ACCEPT_RECIPIENT_IDENTIFIERS_ENABLED feature flag, related code paths, and task definitions
So that the codebase remains efficient and maintainable.

Additional Info and Resources

  • This flag was identified for removal in this spreadsheet, filtered under 'feature flag removal' in the 'removal status' column.

Acceptance Criteria

  • The ACCEPT_RECIPIENT_IDENTIFIERS_ENABLED feature flag, related task definitions, code paths, and tests are removed.
  • Remove code related to the method accept_recipient_identifiers_enabled which uses ACCEPT_RECIPIENT_IDENTIFIERS_ENABLED
  • Any updated logic is covered by tests
  • Test suite and regression tests pass without failure.
  • This work is added to the sprint review slide deck (key win bullet point and demo slide)

QA Considerations

  • POSTv2/notificiations/<notification_type> still works as expected

Potential Dependencies

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants