Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS 19968 - remove CMS toggle usage for phone number migration and use only new fields #2380

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

eselkin
Copy link
Contributor

@eselkin eselkin commented Dec 9, 2024

Summary

  • Removes toggle usage and uses only the new fields that have been used in production
  • Sitewide team
  • Will be removing CMS toggle soon

Related issue(s)

Testing done

  • Manually tested in tugboat and RI

Screenshots

Staff profile Screenshot 2024-12-10 at 11 56 13 AM
Leadership page Screenshot 2024-12-10 at 11 56 45 AM
Kind of cut off MH phone on VAMC System Locations page Screenshot 2024-12-10 at 11 57 12 AM
VAMC Facility MH Number Screenshot 2024-12-10 at 11 57 29 AM
MH Service Location Main MH Num Screenshot 2024-12-10 at 11 57 48 AM
Press release number using Bio number Screenshot 2024-12-10 at 11 58 13 AM

What areas of the site does it impact?

Affects code (but no visible difference from prod)

  • Staff profile phone number
  • Leadership page phone numbers
  • MH Phone number on System locations page
  • MH Phone number on VAMC facility pages
  • MH Service Location Main number on VAMC facilities
  • Press releases with contact phone numbers

Acceptance criteria

  • Update content-build code to stop using FEATURE_TELEPHONE_MIGRATION_V1, and present new phone number treatment all the time

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

Requested Feedback

Check VAMC locations pages eg: /eastern-oklahoma-health-care/locations/
Check any of the facilities of those locations
Check MH service of VAMC facilities of any of those locations
Check leadership eastern-oklahoma-health-care/about-us/leadership/
Check news releases: /eastern-oklahoma-health-care/news-releases/eastern-oklahoma-va-health-care-system-celebrates-caregivers-during-national-family-caregivers-month/

@va-vfs-bot va-vfs-bot temporarily deployed to master/main/VACMS-19968-take-out-FEATURE_TELEPHONE_MIGRATION_V1 December 9, 2024 18:51 Inactive
@eselkin eselkin marked this pull request as ready for review December 10, 2024 21:41
@eselkin eselkin requested review from a team as code owners December 10, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants