VACMS-18765 Cross-repository style cleanup

[randimays]

Summary

When content-build and vets-website were separated into their distinct repositories, styles were left behind in vets-website that applied to content-build selectors. Similarly, content-build and vets-website have some elements that share style declarations in vets-website.

After a recent prod issue and post mortem, Micah (DST) made a spreadsheet of class names that have crossover between repos: https://dsva.slack.com/archives/C06V7AAFVH7/p1722024302075569

Related issue(s)

• Cross-repository style cleanup va.gov-cms#18765

Testing done

I duplicated Micah's spreadsheet to track what action we can take for each cross-referenced class name: https://docs.google.com/spreadsheets/d/1fsrAN3VFHASZ34UvTCBbvBoPF9FPda-YB07NOZ5nZyM/edit?usp=sharing

When appropriate, I:
🍎 moved VW styles to CB that were not being referenced otherwise in VW
🍌 deleted CB or VW class names with no style declarations anywhere
🍇 replaced the class name with a VADS / design system class

Here are links to DSVA searches to show how the classes are used and URLs that can be used to validate on this branch and in production that the proper changes have been made.

☑️ /outreach-and-events/outreach-materials/
🍇 asset-body-text: Replaced the class with vads-u-padding-bottom--1p5 since the class was only adding the same padding.
🍎 asset-body-wrap, asset-component-library, asset-head-wrap, asset-body-wrap, card-inside-wrap, no-results (This one is an ID), outreach-asset-form-filters
🍌 va-page-numbers

☑️ /boston-health-care/work-with-us/jobs-and-careers/nursing-careers/
🍎 bio-paragraph-image, circular-profile-image

☑️ /boston-health-care/about-us/leadership/
🍎 bio-image

☑️ /south-texas-health-care/
🍎 darken, duotone, lighten, region-list, vads-facility-hub-cta, when-where-width
🍌 event-date, event-time
🍇 vads-facility-hub-cta-last-line

☑️ /madison-health-care/events/72063/
🍎 event-detail-img, registration - This one has a ton of search results, you'll have to check the prod page to validate that not
🍇 va-c-social-icon

☑️ /south-texas-health-care/locations/audie-l-murphy-memorial-veterans-hospital/
🍎 facilities_health_service, inline-table-helper, operating-status-link - This would have to be simulated locally; it requires finding facilities that are closed or otherwise inoperative, vads-facility-hub-cta-circle, vads-facility-hub-cta-last-line

☑️ Home page
🍎 homepage-benefits-row, homepage-blog, homepage-blog__image
🍌 veteran-banner-container
🍎 show-on-focus, va-notice--banner - I added the css-library import to accommodate this one per DS recommendation

☑️ /southeast-louisiana-health-care/staff-profiles/mark-morgan/
🍎 left-side-nav-title, person-profile-detail-page-image, va-c-margin-top--auto

☑️ /tuscaloosa-health-care/operating-status/
🍌 operating-status
🍎 table-of-contents

☑️ /initiatives/vote
🍎 va-c-blue-line, va-c-blue-line--large, va-u-background--gradiant-blue (also fixed spelling of "gradient")
🍇 va-u-text-transform--uppercase

☑️ /alexandria-health-care/stories/
🍎 va-facility-page

☑️ /resources
🍎 va-hide-on-print-view

☑️ /outreach-and-events/events
🍎 va-l-detail-page

☑️ /huntington-va-regional-benefit-office/
🍇 vamc-facility-expandable-alert

☑️ Couldn't find a test page for this one; not sure we have a prod example? It's for a sidebar I couldn't find rendering anywhere.
🍎 new-grid, sidenav-previous-page, va-c-facility-sidebar, va-drupal-sidebarnav

☑️ No test link in production. The template (situation_updates.drupal.liquid) does not have any prod content right now.
🍎 no-p-bottom-margin

☑️ No test link in production. The template (media_list_images.drupal.liquid) is not used in production.
🍎 media-list-images
🍇 va-c-position--absolute, va-c-position--relative, va-c-video

☑️ No test link in production. The template (facilities_events_toggle.drupal.liquid) is not used in production.
🍎 half-em-bottom-margin, no-left-button-right-radius-treatment, no-right-button-left-radius-treatment

☑️ No test link in production. The template (operation_status_information.drupal.liquid) is not used in production.
🍎 operating-status-flag, operating-status-flag-notice, operating-status-flag-warning, operating-status-flag-error

☑️ These are used in the home page template that we used while transitioning to the new home page design. That template (home.html) is not used in production.
🍎 homepage-benefits (This one is an ID), homepage-heading, homepage-hub, homepage-hub-container, homepage-image-wrapper, homepage-news, homepage-news-story-desc, homepage-news-story-title, homepage-popular (This one is an ID), hub-links-container, hub-links-list
🍌 homepage-button-icon, hub-links-row

☑️ No test link in production. These class names had a style declaration in vets-website but the class wasn't used in VW or CB.
🍌 vads-facility-hub-cta-arrow, vads-facility-hub-cta-label