You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There is no return of the docker build / docker push return code. When the docker build fails, the pipeline still passes, which leads to unexpected results when the deployment to kubernetes happens.
Should i do a pull request, or do you think it would make the example too complicated? Maybe just a comment about the problem in the code, so anybody using something like this in production cough would have less pain :D
This repo has been very helpful, thank you for that!
The text was updated successfully, but these errors were encountered:
Hi Dennis,
in the build script, for example here:
phoenix/scripts/build_multicalculator.sh
Line 3 in d33179a
There is no return of the docker build / docker push return code. When the docker build fails, the pipeline still passes, which leads to unexpected results when the deployment to kubernetes happens.
Should i do a pull request, or do you think it would make the example too complicated? Maybe just a comment about the problem in the code, so anybody using something like this in production cough would have less pain :D
This repo has been very helpful, thank you for that!
The text was updated successfully, but these errors were encountered: