Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Script: Return Code Handling #17

Open
StefanS-O opened this issue Jul 22, 2020 · 0 comments
Open

Build Script: Return Code Handling #17

StefanS-O opened this issue Jul 22, 2020 · 0 comments

Comments

@StefanS-O
Copy link

Hi Dennis,

in the build script, for example here:

build_push_container () {

There is no return of the docker build / docker push return code. When the docker build fails, the pipeline still passes, which leads to unexpected results when the deployment to kubernetes happens.

Should i do a pull request, or do you think it would make the example too complicated? Maybe just a comment about the problem in the code, so anybody using something like this in production cough would have less pain :D

This repo has been very helpful, thank you for that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant