Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RecursionError in Dendrogram.load_from #166

Open
GiantMolecularCloud opened this issue Sep 12, 2019 · 0 comments
Open

RecursionError in Dendrogram.load_from #166

GiantMolecularCloud opened this issue Sep 12, 2019 · 0 comments

Comments

@GiantMolecularCloud
Copy link

I computed a dendrogram with 12k structures and saved it as a fits file. When trying to reload this dendrogram I ran into a RecursionError in collect(d) in io/util.py.

The system recursion limit (sys.getrecursionlimit()) on my machine is 3000 and raising the limit to 10000 works around the issue. Interestingly, this error does not occur for another dendrogram with 7600 structures that is also way beyond the limit.

It might be helpful and generally favourable to rewrite the problematic function to use iterations instead of recursions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant