Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plot.py updates from Miguel #47

Open
demisjohn opened this issue Mar 13, 2023 · 1 comment
Open

Plot.py updates from Miguel #47

demisjohn opened this issue Mar 13, 2023 · 1 comment

Comments

@demisjohn
Copy link
Owner

demisjohn commented Mar 13, 2023

@mdaal contributes the attached plot.py, which includes his following features:
Plot_mdaal.py.zip

I have extended JobCreator to include the functionality so that plot wafer can plot the image distribution per layer (and per image) eg

MyJob.plot_wafer(plot_set = LAYER_1) # Layer object passed
Or
MyJob.plot_wafer(plot_set = {‘box’, ‘trace’} # Layer_ID string passed

Where box and trace are images defined. This functionality is very helpful for when your job has a lot of images and layers that overlap.

Agreed, this will be very helpful!

Suggestions:
Change argument name plot_set=-->layer=

Need to parse and fold this into the module, and test for functionality/bugs.

@fyodr
Copy link
Contributor

fyodr commented May 2, 2023

Merged with a new commit. Changed argument name as suggested. Removed support for Layer object arguments -- only supports selection by LayerID strings.

Also, Miguel's code passes out a dictionary called patch_dict. I think the purpose is to let the user plot the patches on a different figure? If so, you can do that now by passing the target (figure, axis) as an argument to plot_wafer. If not, it should be easy to add back in, and sorry for leaving it out in this commit.

Otherwise, I think I preserved all functionality.

I have pushed to my fork. Will send a pull request soon, after a little more debugging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants