Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize the export_lib.py > add() function #40

Open
demisjohn opened this issue Aug 15, 2022 · 1 comment
Open

Generalize the export_lib.py > add() function #40

demisjohn opened this issue Aug 15, 2022 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@demisjohn
Copy link
Owner

Currently the add() function in export_lib.py, which formats values appropriately for the text export, has a hokey kludge of if/elif statements that are each specific to a particular text line.

eg.
"WAFER_ALIGN_REPEATS" uses elif np.size(val) == 10:... or
"OptPrealignment Marks " uses elif np.size(val)==2 ... AND if doubelstr==True

Instead should generalize for general code readability (eg. use on another system) using arguments to determine format, instead of size( ) of the list passed.

Arguments should only be things like "quoted", "string", "integer", "float" etc.
Thus another developer could guess how it's going to get formatted from the arguments passed. Currently, instead a different format is applied depending on the np.size( ) of the vlaue list passed, which would require a dev to scour the add( ) function to figure out what it's actually going to do!

Here's a link to the add() function:
https://github.com/demisjohn/ASML_JobCreator/blob/master/ASML_JobCreator/exportlib.py#L36

@demisjohn demisjohn added the enhancement New feature or request label Aug 15, 2022
@demisjohn
Copy link
Owner Author

demisjohn commented Jan 8, 2023

Should implement Tests before trying this, to make sure nothing breaks in the output text file.

See issue on adding tests here: #17

@demisjohn demisjohn self-assigned this Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant