Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tab-navigation incomplete/erroneous #4127

Closed
5 of 6 tasks
r10s opened this issue Sep 12, 2024 · 4 comments · Fixed by #4294
Closed
5 of 6 tasks

tab-navigation incomplete/erroneous #4127

r10s opened this issue Sep 12, 2024 · 4 comments · Fixed by #4294
Assignees
Labels
accessibility bug Something isn't working

Comments

@r10s
Copy link
Member

r10s commented Sep 12, 2024

#4005 adds "tab navigation" to improve accessibility, so to help users who cannot or do not want to use a mouse.

the idea of the "tab navigation" is that it can replace a mouse completely.

however, there are some open ends with the navigation:

sorry for nitpicking, but to make "tab navigation" useful, it should be coherent.

note, that "other shortcuts" are are more for power-users and are not a replacement for "tab navigation" issues: "tab navigation" should be useful without learning additional shortcuts, as said, being used as a mouse replacement

for further reading see eg. https://www.nngroup.com/articles/keyboard-accessibility/

@r10s r10s added the bug Something isn't working label Sep 12, 2024
@WofWca WofWca self-assigned this Sep 12, 2024
@WofWca
Copy link
Collaborator

WofWca commented Sep 17, 2024

Could you clarify these?

in the message list, random "emoji picker" icons are selected - the ones the mouse is hovered

there is not tab-stop for the "profile"

What profile?

@r10s
Copy link
Member Author

r10s commented Sep 17, 2024

Could you clarify these?

in the message list, random "emoji picker" icons are selected - the ones the mouse is hovered

see the following image:

the mouse is randomly over the message "gg" - and then the buttons beside the message can be reached via tab. but this does not make sense, the whole idea of the tab-navigation is that the mouse is not needed. and you cannot reach the context menu of another message without mouse.

there is not tab-stop for the "profile"

What profile?

the one that opens when tapping here:

@Simon-Laux
Copy link
Member

Settings: selections dialog elements and switch elements are not focusable:

Bildschirmaufnahme.2024-10-07.um.18.53.07.mp4

@maxphilippov
Copy link
Collaborator

maxphilippov commented Oct 7, 2024

Settings: selections dialog elements and switch elements are not focusable:
Bildschirmaufnahme.2024-10-07.um.18.53.07.mp4

Selects are selectable in #4006 and probably in main, Radio groups are probably what you mean, switches aren't selectable

That's a pretty easy fix, I'll add that to #4006, so we don't drown in merges

WofWca added a commit that referenced this issue Oct 19, 2024
Partially addresses #4127

FYI the `@mixin button-reset` is actually only used in one place.
WofWca added a commit that referenced this issue Oct 19, 2024
Partially addresses #4127

FYI the `@mixin button-reset` is actually only used in one place.
WofWca added a commit that referenced this issue Oct 21, 2024
Partially addresses #4127

FYI the `@mixin button-reset` is actually only used in one place.
WofWca added a commit that referenced this issue Oct 22, 2024
Partially addresses #4127

FYI the `@mixin button-reset` is actually only used in one place.
WofWca added a commit that referenced this issue Oct 29, 2024
Partially addresses #4127

FYI the `@mixin button-reset` is actually only used in one place.
WofWca added a commit that referenced this issue Nov 1, 2024
Partially addresses #4127

FYI the `@mixin button-reset` is actually only used in one place.
WofWca added a commit that referenced this issue Nov 1, 2024
Partially addresses #4127

FYI the `@mixin button-reset` is actually only used in one place.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants