Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further simplify delphin.tsdb module #258

Open
goodmami opened this issue Nov 29, 2019 · 0 comments
Open

Further simplify delphin.tsdb module #258

goodmami opened this issue Nov 29, 2019 · 0 comments
Labels
maintenance improving code quality; not features or bugs

Comments

@goodmami
Copy link
Member

For purposes of type-checking (which help to reveal actual bugs), the delphin.tsdb module could be made simpler. Mainly this has to do with function parameters that change the structure of the thing that is returned. For instance:

  • delphin.tsdb.split() should always return a tuple of strings, some separate function should do the casting
  • delphin.tsdb.Database should remove the autocast parameter/attribute
  • delphin.tsdb.Database.select_from() should remove the cast parameter
  • delphin.tsdb.join() should remove the fields parameter (maybe)

Then there would be separate functions for casting or formatting all columns in a record.

These are backwards-incompatible changes, so either they need to be done with different names or wait until v2.0.

@goodmami goodmami added the maintenance improving code quality; not features or bugs label Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance improving code quality; not features or bugs
Projects
None yet
Development

No branches or pull requests

1 participant