You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
For purposes of type-checking (which help to reveal actual bugs), the delphin.tsdb module could be made simpler. Mainly this has to do with function parameters that change the structure of the thing that is returned. For instance:
delphin.tsdb.split() should always return a tuple of strings, some separate function should do the casting
delphin.tsdb.Database should remove the autocast parameter/attribute
delphin.tsdb.Database.select_from() should remove the cast parameter
delphin.tsdb.join() should remove the fields parameter (maybe)
Then there would be separate functions for casting or formatting all columns in a record.
These are backwards-incompatible changes, so either they need to be done with different names or wait until v2.0.
The text was updated successfully, but these errors were encountered:
For purposes of type-checking (which help to reveal actual bugs), the
delphin.tsdb
module could be made simpler. Mainly this has to do with function parameters that change the structure of the thing that is returned. For instance:delphin.tsdb.split()
should always return a tuple of strings, some separate function should do the castingdelphin.tsdb.Database
should remove theautocast
parameter/attributedelphin.tsdb.Database.select_from()
should remove thecast
parameterdelphin.tsdb.join()
should remove thefields
parameter (maybe)Then there would be separate functions for casting or formatting all columns in a record.
These are backwards-incompatible changes, so either they need to be done with different names or wait until v2.0.
The text was updated successfully, but these errors were encountered: