Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Negation choices negating each other #697

Open
emilymbender opened this issue Feb 4, 2024 · 3 comments
Open

Negation choices negating each other #697

emilymbender opened this issue Feb 4, 2024 · 3 comments

Comments

@emilymbender
Copy link
Contributor

With "simple" sentential negation, the choices are given as checkboxes (not radio buttons) but selecting negative auxiliary in addition to negative adverb causes the negative adverb to not be created in the lexicon. E.g. in the attached choices file, there is no adverb entry for "not".
choices.txt

@ajcassell
Copy link
Contributor

@emilymbender since these are checkboxes, I just want to confirm that all options can be true simultaneously, is that correct? They are not mutually exclusive options (which would warrant a radio button). If so, I've found the culprit.

@emilymbender
Copy link
Contributor Author

Yes, that is correct!

@ajcassell
Copy link
Contributor

Update: The negation library needs to be updated to use independent if statements instead of elif logic for simple negation. The questionnaire has checkboxes which implies that multiple options can co-exist. However, the logic prevents more than one which is why the adverb entry above is not created. Changing this logic fixes that. However, we found that in doing this, another bug is revealed with the adnom-poss-grc regression test. The grammar has inflecting and adverbial negation. Before the update, only a parse with the inflecting negation was available. Now, the adverbial negation is present and using adj-head-scop rule. In this grammar, the mod values of nouns is underspecified so as soon as the grammar has an adj-head rule in it, the nouns can attach via this rule when they shouldn't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants