Skip to content
This repository has been archived by the owner on Oct 4, 2022. It is now read-only.

Fix versioning to be accepted into the Rack community repository #13

Open
AndrewBelt opened this issue Dec 18, 2017 · 1 comment
Open

Comments

@AndrewBelt
Copy link

Rack v0.5.1 will include a plugin manager, and plugins need to follow the versioning guidelines in order to be accepted. You can use this example plugin Makefile and Tutorial.cpp file as a reference for making sure the version is the same in the C++, Makefile, and JSON manifest.

  • Your plugin has no version defined in a C++ file. You must set plugin->version using the Tutorial.cpp file as a reference.

Once you've fixed this, send a PR to the Rack community repository, fixing the version is applicable and removing the "disabled" property in the JSON manifest file if present.

@AndrewBelt
Copy link
Author

I've also disabled your plugin from the VCV community repo because the MacOS build is a tarbomb. This would also be fixed by following after the Tutorial repo's Makefile example.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant