Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

private to protected in WebhookHandler #373

Open
BeyCoder opened this issue May 16, 2023 · 6 comments
Open

private to protected in WebhookHandler #373

BeyCoder opened this issue May 16, 2023 · 6 comments

Comments

@BeyCoder
Copy link

Hi, I need to override handleCallbackQuery, but it's a private function. It's impossible to create your own handling of callbackQuery.

I think, here should be protected instead of private

@fabio-ivona
Copy link
Member

Hi, may I ask why do you need to override handleCallbackQuery?

@BeyCoder
Copy link
Author

Hi, may I ask why do you need to override handleCallbackQuery?

Hi. Sure, I have created a plugin system, so, callbackQuery is executing in another class.

Here is an example with a command executing:
image

P.S. Also it's possible to create something like handleUnknownCallbackQuery. Maybe it will be better than changing the accessor.

@fabio-ivona
Copy link
Member

I got your point, will implement a way to handle unknown callback queries soon ;-)

@BeyCoder
Copy link
Author

I got your point, will implement a way to handle unknown callback queries soon ;-)

I can implement and send PR if my help is needed :3

@fabio-ivona
Copy link
Member

Sure! Any help is welcome ❤️ feel free to open a PR

@andrey-helldar
Copy link
Contributor

It was released in 1.53.0 version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants