Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize Poki SDK load and init flow. #18

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ekharkunov
Copy link
Contributor

@ekharkunov ekharkunov commented Nov 27, 2024

Fixes #12

@AGulev AGulev self-requested a review December 9, 2024 09:12
Copy link
Collaborator

@AGulev AGulev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@britzl do you want to take a look?

Copy link
Contributor

@britzl britzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@@ -1,28 +1,45 @@
<!DOCTYPE html>
<head>
<script src="//game-cdn.poki.com/scripts/v2/poki-sdk.js"></script>
<link rel="dns-prefetch" href="//game-cdn.poki.com" />

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this prefetch adds anything as the domain is already used 2 lines below. So browsers will see that at the same time and already start connecting to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optimize Poki sdk loading
4 participants