Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: events fetcher & indexer client #4
feat: events fetcher & indexer client #4
Changes from 2 commits
bdd2b8e
e48358e
e869159
22d1c1a
9cdbedf
a407163
3a95eb4
76ba4f9
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add natspec
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should
blockNumber
be aBigInt
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now I'm thinking if
ProtocolEvent["block_number"]
should also bebigint
🤔There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if we need it actually.
Number.MAX_SAFE_INTEGER = 9007199254740991
:roflThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Viem treats it like
bigint
, we will have an inconsistency here. We need to define a common type at least to the internal limits of our backend, and only convert to number or bigint when interfacing with external (IndexerClient, Viem lib, etc)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Along the lines of Nigiri's comment, it's more of a semantic type thingy.
Whenever you get a block number out of
viem
or any other client, you as a dev will need to know (and be extremely sure) that you are working with a particular set of block numbers that can be safely casted frombigint
tonumber
. By using abigint
, you just forget about that problem in the future. You move from a "it will probably work" scenario to a "it works" scenario.