feat: coingecko pricing provider #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xkenj1
previously approved these changes
Oct 8, 2024
0xyaco
reviewed
Oct 8, 2024
packages/pricing/package.json
Outdated
| "scripts": { | ||
| "build": "tsc -p tsconfig.build.json", | ||
| "check-types": "tsc --noEmit -p ./tsconfig.json", | ||
| "clean": "rm -rf dist", |
There was a problem hiding this comment.
This is just as a bonus, if you add a trailing slash you are forcing rm to remove a dist folder (if it's a dist file it's not removed):
Suggested change
| "clean": "rm -rf dist", | |
| "clean": "rm -rf dist/", |
There was a problem hiding this comment.
we can add this to the boilerplate
| baseURL, | ||
| headers: { | ||
| common: { | ||
| [authHeader]: apiKey, |
There was a problem hiding this comment.
Just in case asking, does the apiKey expire?
There was a problem hiding this comment.
noup, it's long lived
Comment on lines
+92
to
+93
| const startTimestampSecs = Math.floor(startTimestampMs / 1000); | ||
| const endTimestampSecs = Math.floor(endTimestampMs / 1000); |
There was a problem hiding this comment.
What happens if start > end? No results? API failure?
There was a problem hiding this comment.
aaa good catch, will add that validation
0xkenj1
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 Linear
Closes GIT-67
Description
pricingpackage withCoingeckoProviderIPricingProviderfor future extensibilityChecklist before requesting a review