fix: pr comments

defi-wonderland · Oct 8, 2024 · 4bf5c33 · 4bf5c33
1 parent 98324ea
commit 4bf5c33
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 1 deletion.
diff --git a/packages/pricing/package.json b/packages/pricing/package.json
@@ -19,7 +19,7 @@
     "scripts": {
         "build": "tsc -p tsconfig.build.json",
         "check-types": "tsc --noEmit -p ./tsconfig.json",
-        "clean": "rm -rf dist",
+        "clean": "rm -rf dist/",
         "format": "prettier --check \"{src,test}/**/*.{js,ts,json}\"",
         "format:fix": "prettier --write \"{src,test}/**/*.{js,ts,json}\"",
         "lint": "eslint \"{src,test}/**/*.{js,ts,json}\"",

diff --git a/packages/pricing/src/providers/coingecko.provider.ts b/packages/pricing/src/providers/coingecko.provider.ts
@@ -89,6 +89,10 @@ export class CoingeckoProvider implements IPricingProvider {
             throw new UnsupportedChainException(chainId);
         }
 
+        if (startTimestampMs > endTimestampMs) {
+            return undefined;
+        }
+
         const startTimestampSecs = Math.floor(startTimestampMs / 1000);
         const endTimestampSecs = Math.floor(endTimestampMs / 1000);
 

diff --git a/packages/pricing/test/providers/coingecko.provider.spec.ts b/packages/pricing/test/providers/coingecko.provider.spec.ts
@@ -91,6 +91,17 @@ describe("CoingeckoProvider", () => {
             expect(result).toBeUndefined();
         });
 
+        it("return undefined when endTimestamp is greater than startTimestamp", async () => {
+            const result = await provider.getTokenPrice(
+                1,
+                "0x1234567890123456789012345678901234567890" as Address,
+                1609545600000, // startTimestamp
+                1609459200000, // endTimestamp
+            );
+
+            expect(result).toBeUndefined();
+        });
+
         it("return undefined if 400 family error", async () => {
             mock.onGet().replyOnce(400, "Bad Request");