feat: base pkg structure #8
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xjjojo
commented
May 23, 2024
.env.example
Outdated
| @@ -0,0 +1,2 @@ | |||
| COINGECKO_API_URL="" | |||
There was a problem hiding this comment.
this could be done at package level ?? I think 🤔 cc @0xkenj1
There was a problem hiding this comment.
Yep, each of the packages that has runtime should have its own env vars
ZKS-15 Implement base packages
we will use this packages as reference starting point. |
…s, and declare new example package
…config point to correct tsconfig
…ecated files and js outputs, refactor cg constructor
0xkenj1
requested changes
May 24, 2024
packages/errors/package.json
Outdated
| "devDependencies": { | ||
| "@hyperhub/test-config": "workspace:*", | ||
| "@hyperhub/typescript-config": "workspace:*", | ||
| "typescript": "5.4.5", |
There was a problem hiding this comment.
this shoould be a global dependency of the monorepo
packages/errors/package.json
Outdated
| "@hyperhub/test-config": "workspace:*", | ||
| "@hyperhub/typescript-config": "workspace:*", | ||
| "typescript": "5.4.5", | ||
| "vitest": "1.6.0" |
There was a problem hiding this comment.
this should only be a dep from test-config or iam wrong ?
packages/lib/coingecko/package.json
Outdated
Comment on lines
16
to
17
| "typescript": "4.9.4", | ||
| "vitest": "1.6.0" |
packages/lib/coingecko/src/index.ts
Outdated
Comment on lines
10
to
23
| const baseURL = process.env.COINGECKO_API_URL; | ||
| const apiKey = process.env.COINGECKO_API_KEY; | ||
|
|
||
| if (!baseURL) { | ||
| throw new Error("Missing Coingecko baseUrl"); | ||
| } | ||
|
|
||
| if (!apiKey) { | ||
| throw new Error("Missing coingecko api key"); | ||
| } | ||
|
|
||
| this.apiKey = apiKey; | ||
| this.baseURL = baseURL; | ||
|
|
There was a problem hiding this comment.
lets use the approach we have talked offline
| @@ -3,7 +3,7 @@ | |||
| "globalDependencies": ["**/.env.*local"], | |||
| "pipeline": { | |||
| "build": { | |||
| "dependsOn": ["^build"], | |||
0xkenj1
approved these changes
May 27, 2024
Merged
0xjjojo
added a commit
that referenced
this pull request
May 27, 2024
# 🤖 Linear Re implements #8 without commit issues ## Description
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 Linear
Closes ZKS-15
Description