refactor: cg constructor w dep inyection

defi-wonderland · May 24, 2024 · cdc21b4 · cdc21b4
1 parent 8308e08
commit cdc21b4
Showing 1 changed file with 9 additions and 25 deletions.
diff --git a/packages/lib/coingecko/src/index.ts b/packages/lib/coingecko/src/index.ts
@@ -3,33 +3,17 @@ import axios from "axios";
 
 export default class CoingeckoService {
     private instance: AxiosInstance;
-    private baseURL: string;
-    private apiKey: string;
-
-    constructor() {
-        const baseURL = process.env.COINGECKO_API_URL;
-        const apiKey = process.env.COINGECKO_API_KEY;
-
-        if (!baseURL) {
-            throw new Error("Missing Coingecko baseUrl");
-        }
-
-        if (!apiKey) {
-            throw new Error("Missing coingecko api key");
-        }
-
-        this.apiKey = apiKey;
-        this.baseURL = baseURL;
 
+    constructor(private url: string, private apiKey:string){
         const config: CreateAxiosDefaults = {
-            baseURL: this.baseURL,
-            headers: {
-                "x-cg-demo-api-key": this.apiKey,
-            },
-        };
-
-        this.instance = axios.create(config);
-    }
+                  baseURL: url,
+                  headers: {
+                      "x-cg-demo-api-key": this.apiKey,
+                  },
+              };
+      
+              this.instance = axios.create(config);
+      }
 
     get(): AxiosInstance {
         if (!this.instance) {