feat: calculate arbitrum block number for start of epoch #71
Conversation
| @@ -309,10 +313,18 @@ export class ProtocolProvider implements IProtocolProvider { | |||
| blockNumber: epochFirstBlockNumber, | |||
| }); | |||
|
|
|||
| const startTimestamp = epochFirstBlock.timestamp as UnixTimestamp; | |||
There was a problem hiding this comment.
Let's make the blockNumberService dependency optional so we don't have to worry about creating a mocked version of it within the recently developed scripts. Let's make it so ProtocolProvider fails if someone tries to get a current epoch without passing a block number service when initializing it.
| const expectedAddress = privateKeyToAccount(mockedPrivateKey).address; | ||
| const expectedAddress = privateKeyToAccount( | ||
| mockedPrivateKey, | ||
| mockBlockNumberService, |
There was a problem hiding this comment.
it is not, it appears my linter is on strike. I removed it
| @@ -247,10 +255,15 @@ describe("ProtocolProvider", () => { | |||
| const mockEpochBlock = BigInt(12345); | |||
| const mockEpochTimestamp = BigInt(Date.UTC(2024, 1, 1, 0, 0, 0, 0)) / 1000n; | |||
|
|
|||
| const mockBlockNumberService = { | |||
| getEpochBlockNumber: vi.fn().mockResolvedValue(mockEpochBlock), | |||
There was a problem hiding this comment.
We should differentiate the getEpochBlockNumber from block number service from the block number returned by the epoch manager contract, just to be sure that one is the L1 block number (contract's one) and the BN service response is L2 (which should actually be used in the return value).
…-arbitrum-block-num # Conflicts: # packages/automated-dispute/src/providers/protocolProvider.ts # packages/automated-dispute/tests/services/protocolProvider.spec.ts
| rpcConfig, | ||
| contracts, | ||
| env.PRIVATE_KEY as Hex, | ||
| mockBlockNumberService, |
There was a problem hiding this comment.
You should be able to drop this with the new changes! I think you'll need to add the optionality for BlockNumberService in the ProtocolProvider constructor
There was a problem hiding this comment.
oops this got filtered out in the merge
🤖 Linear
Closes GRT-214
Description