fix: blocknumber binsearch #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xyaco
force-pushed
the
fix/blocknumber-binsearch
branch
from
d649524 to
23ec54e
Compare
jahabeebs
previously approved these changes
Oct 23, 2024
packages/blocknumber/package.json
Outdated
| @@ -25,6 +25,7 @@ | |||
| "dependencies": { | |||
| "@ebo-agent/shared": "workspace:*", | |||
| "axios": "1.7.7", | |||
| "bignumber.js": "^9.1.2", | |||
jahabeebs
previously approved these changes
Oct 23, 2024
0xnigir1
reviewed
Oct 24, 2024
Comment on lines
266
to
294
| private async getNextBlockWithDifferentTimestamp( | ||
| block: BlockWithNumber, | ||
| ): Promise<BlockWithNumber | null> { | ||
| let nextBlock: BlockWithNumber = block; | ||
|
|
||
| try { | ||
| while (nextBlock.timestamp === block.timestamp) { | ||
| nextBlock = await this.client.getBlock({ blockNumber: nextBlock.number + 1n }); | ||
| } | ||
|
|
||
| return nextBlock; | ||
| } catch (err) { | ||
| if (err instanceof BlockNotFoundError) { | ||
| // This covers the case where the search surpasses the latest block | ||
| // and no more blocks are found by block number. | ||
| return null; | ||
| } else { | ||
| throw err; | ||
| } | ||
| } | ||
| } | ||
|
|
||
| /** | ||
| * Search the block with the lowest height that has the same timestamp as `block`. | ||
| * | ||
| * @param block the block to use in the search | ||
| * @returns a block with the same timestamp as `block` and with the lowest height. | ||
| */ | ||
| private async searchFirstBlockWithEqualTimestamp( |
There was a problem hiding this comment.
maybe call this getFirstBlockWithEqualTimestamp or the other function searchNextBlockWithDifferentTimestamp, so you keep a naming convention for search/get functions
There was a problem hiding this comment.
Nice suggestion, I think I'll go with search; feels like a more appropriate naming for O(n) lookups.
get feels like more appropriate for O(1) functions, wdty?
Comment on lines
136
to
138
| let candidateBlockNumberBN = new BigNumber(lastBlock.number.toString()) | ||
| .dividedBy(timestampDeltaBN.dividedBy(estimatedBlockTimeBN)) | ||
| .integerValue(); |
There was a problem hiding this comment.
is this okay? original code is: let candidateBlockNumber = lastBlock.number - timestampDelta / estimatedBlockTime; and you're doing two divisions (idk if im missing smth on the math)
There was a problem hiding this comment.
Oh boy what a nice catch 🎯
0xnigir1
approved these changes
Oct 24, 2024
jahabeebs
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 Linear
Closes GRT-226
Description