Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(kernel-rolling) PCI: Mark Px210 PCI-E Extended Tags as broken #237

Conversation

MingcongBai
Copy link
Contributor

@MingcongBai MingcongBai commented May 28, 2024

Picked and rebased from #223.

From original pull request:

Per PCIe r3.1, sec 2.2.6.2 and 7.8.4, a Requester may not use 8-bit Tags unless its Extended Tag Field Enable is set, but all Receivers/Completers must handle 8-bit Tags correctly regardless of their Extended Tag Field Enable.

Phytium Px210 chipset has some issues with 8-bit Tags enabled when doing DMA operations, add this quirk to disable Extended Tags for the entire hierarchy to avoid the problem.

Builds tested

  • amd64
  • arm64
  • loong64

Per PCIe r3.1, sec 2.2.6.2 and 7.8.4, a Requester may not use 8-bit
Tags unless its Extended Tag Field Enable is set, but all
Receivers/Completers must handle 8-bit Tags correctly regardless of
their Extended Tag Field Enable.

Phytium Px210 chipset has some issues with 8-bit Tags enabled when
doing DMA operations, add this quirk to disable Extended Tags for
the entire hierarchy to avoid the problem.

Signed-off-by: Liu Tao <[email protected]>
Signed-off-by: Chen Baozi <[email protected]>
Signed-off-by: Wang Yinfeng <[email protected]>
Signed-off-by: Wang Zhimin <[email protected]>
Signed-off-by: wangzhimin1179 <[email protected]>
@MingcongBai MingcongBai force-pushed the bai/kernel-rolling/phytium-x11-pcie-quirk branch from b82a239 to 6c909b1 Compare May 29, 2024 00:41
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign zccrs for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • 新增的DECLARE_PCI_FIXUP_EARLY宏调用缺少对应的宏定义确认是否已定义
  • 新增的代码行缺少了分号

是否建议立即修改:

@opsiff
Copy link
Member

opsiff commented Jun 14, 2024

/lgtm

@opsiff opsiff merged commit 28d8e6b into deepin-community:kernel-rolling Jun 14, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants