From 36e195408c9edd8cec3240b02e490a84c61eb0a9 Mon Sep 17 00:00:00 2001 From: WangYuli Date: Fri, 22 Nov 2024 12:44:18 +0800 Subject: [PATCH] eth: mucse: rnp: remove extraneous parentheses around the comparison Fix follow error with clang-19: drivers/net/ethernet/mucse/rnp/rnp_main.c:6165:24: error: equality comparison with extraneous parentheses [-Werror,-Wparentheses-equality] 6165 | } else if ((protocol == htons(ETH_P_8021Q))) { | ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~ drivers/net/ethernet/mucse/rnp/rnp_main.c:6165:24: note: remove extraneous parentheses around the comparison to silence this warning 6165 | } else if ((protocol == htons(ETH_P_8021Q))) { | ~ ^ ~ drivers/net/ethernet/mucse/rnp/rnp_main.c:6165:24: note: use '=' to turn this equality comparison into an assignment 6165 | } else if ((protocol == htons(ETH_P_8021Q))) { | ^~ | = 1 error generated. Signed-off-by: WangYuli --- drivers/net/ethernet/mucse/rnp/rnp_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mucse/rnp/rnp_main.c b/drivers/net/ethernet/mucse/rnp/rnp_main.c index 59d7873bf017..db7927f70cea 100644 --- a/drivers/net/ethernet/mucse/rnp/rnp_main.c +++ b/drivers/net/ethernet/mucse/rnp/rnp_main.c @@ -6162,7 +6162,7 @@ netdev_tx_t rnp_xmit_frame_ring(struct sk_buff *skb, * protocol and store the tag */ /* veb only use ctags */ - } else if ((protocol == htons(ETH_P_8021Q))) { + } else if (protocol == htons(ETH_P_8021Q)) { struct vlan_hdr *vhdr, _vhdr; vhdr = skb_header_pointer(skb, ETH_HLEN, sizeof(_vhdr),