Photo editor

[Donkey-Doug]

Add a basic photo editor with support for:

• Cropping (free form, 1:1, 16:9, device ratio)
• Rotating (I recomment just one button that rotates 90 degrees. Can be pressed multiple times to rotate 180 or 270 degrees)
• Annotating (drawing lines of varying thickness and color, writing text)
• Blurring part of an image to protect privacy sensitive info.

---

Examples:
Radial blur:

Inverted radial blur:

Inverted rectangular blur:

[deckerst]

Planned but not in the short term, as some other core features and performance issues must be tackle first. For rotating and mirroring, you can already do so with the image viewer menu. There's a line with 3 icon buttons: rotate CCW, rotate CW, and horizontal flip. They do not modify the image itself, they modify the metadata, so it's lossless.

…

On Mon, Jan 4, 2021 at 11:45 AM Donkey-Doug ***@***.***> wrote: Add a basic photo editor with support for: - Cropping (free form, 1:1, 16:9) - Rotating (I recomment just one button that rotates 90 degrees. Can be pressed multiple times to rotate 180 or 270 degrees) - Annotating (drawing lines of varying thickness and color, writing text) - Black-and-White filter to remove colors — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#17>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADKBEXK5OPUZC3HZGV66E3LSYETTZANCNFSM4VSMQVGQ> .

[Subbarao6338]

Also add lighten images

[RuthlessRuler]

Any timeline when the Photo Editing Features will be added?

[deckerst]

Nope. I do not have timelines for this personal project. I try to fix bugs as soon as they emerge, but features are just things I'd like to do someday.

Is it troublesome to use another app for editing, like Snapseed?

[bornhustler07]

Snapseed is close source 🙂

[bornhustler07]

If you will consider maybe same day to add photo editor just simple editor kinda like simple gallery app it will be nice👍

[Darkempire78]

basic edit is clearly the most important improvements to be made

[rusty-snake]

I think Signal's photo editing is the best way to edit photos ATM if you want OSS. Somebody could make an standalone app for it.

[RuthlessRuler]

Simple Gallery Pro also has a nice feature rich Photo Editing Tools.

[mitchwalton]

Looking forward to a quality photo editor in Aves when he gets to it. However, this app doesn't collect personal info and is a powerful photo editor. Give it a try! If your still concerned about data collection deny it internet permission through the ROM or with Netguard.

https://apkcombo.com/img-ly-photo-video-editor/com.photoeditorsdk.android.app/

[Svetov1d]

built-in editor would be great, add it and i'm switching completely to Aves. I would love to have one app to browse and edit images like simple gallery does

[arthuragone]

The best goal of adding a photo editor within Aves would be the possibility not to modify Exif date and position data.
At the moment if you edit your picture with Snapseed as an example, it modify picture date as today and wipe out location data. Same behavior with GrapheneOs internal gallery and editor.

[opk12]

Calling an external third-party component (Edit menu to open a specialized editor app) is the optimal approach, from a purely software engineering POV. Widespread software design guidelines deprecate reinventing bloat in-app. As a programmer, I value the simplicity and agility of Aves, in comparison to bloated apps. But if implementing an editor were the way to go, what about integrating a lib?

• PhotoEditor does draw, text, filters, stickers, undo / redo.
  It can be embedded as a library and here are the known host apps. Notably, it is embedded in Screenshot Tile and the F-droid version thereof. So it is F-droid-ready.
  In PhotoEditor's feature request for cropping, a contributor also suggested uCrop.
• uCrop does crop, rotate, scale. It can be embedded as a library, however the last commit is very old (is it maintained today?).

Cons are the bigger app size; the maintainance burden of keeping up with library releases; the risk that the lib becomes unmaintained in the future, with security issues. But reinventing the wheel in this app would be the worst option, heavier on the devs, and the users would not get as a powerful UI.

[opk12]

Also ImageToolbox, is under active development, featureful, already in F-droid.

[rusty-snake]

Featureful but lacks in UX.

[tsutaya0225]

I agree that the most basic editing functions are necessary, but I don't think anything more than that should be considered now. (I agree with Donkey-Doug who was the first to speak up).
However, I would also like to see crop presets for common photo ratios (3:2, 4:3, 7:5).
I am currently getting by with external apps, so I would be very happy if you could implement this when you can afford it.

[hj-collab]

I've switched to Aves from Simple Gallery Pro since ZipoApps acquired Simple Mobile Tools. Hoping for basic editing features in Aves in the future, as Simple Gallery Pro had a great built-in image editor.

[guglovich]

It's the only normal app in F-Froid. I'm looking forward to basic photo cropping.

[derei]

@deckerst I understand there is a lot of work to do ahead, before you may consider adding new features. However, cropping an image is one of the most used features on mobile devices.
And yes, I'm sure some will say that "annotation", or adding text, stickers, emoji, is what they use most... or color balance, or whatnot. But if we're bein purely objective, the basic ol' crop feature is not only the one present in all photo gallery apps, even those without advanced editing, but is the most used and useful to have at fingertips.

Whilst for advanced editing there are alternatives, I believe that adding a crop feature as a quick modifier, would only benefit the app, and perhaps it could be released before any major update.

Many thanks.

[Iprobablydontknowwhatimdoing]

I love snapseed, but it's closed source, and also by google, So they will probably shut it down and they remember it exists.

[deckerst]

@Iprobablydontknowwhatimdoing let me know when it's in https://killedbygoogle.com/ :D

[lordofscripts]

Every Android comes with a basic editor, some lack this or that, others have this and that.

Personally, I think adding Yet Another Basic Photo Editor. would be a waste of valuable resources and bloat ASVES unnecessarily.

Let AVES excel at what it does.

[Aadam-Marshall]

Every Android comes with a basic editor, some lack this or that, others have this and that.

Personally, I think adding Yet Another Basic Photo Editor. would be a waste of valuable resources and bloat ASVES unnecessarily.

Let AVES excel at what it does.

Read carefully and closely this entire thread. People need basic editing features, it's an essential element of a full-fledged gallery app. Even Simple Gallery, truly one of the most simple gallery apps - has cropping and drawing on images. Labeling, for example, cropping functionality as "bloat" is insane. People's needs in this issue are totally valid. They don't want to inconveniently compartmentalize between an image editing app and a gallery app. They want to view their images and edit their images all in one app. It's crystal clear that it's not convenient at all to be viewing your pics in Aves, and then having to need to open another app because you suddenly needed to simply crop a photo.
Here's an appropriate analogy: "I use Telegram for messaging, but Telegram doesn't support video calls [let's imagine]. But that's not a problem! I'm just gonna download another app for video calling. Just let Telegram do what it does - only text messaging. Let's not add bloat and waste valuable resources of Telegram's team on adding video calls!"

Every Android comes with a basic editor, some lack this or that, others have this and that.

Privacy-conscious people won't use a proprietary preinstalled gallery app. Just ask around. I disabled the preinstalled gallery app on my Samsung and have never used it, despite it having editing capabilities. People have Xiaomi and other vendors, and there are privacy-conscious people among them, and I'm quite sure they don't use their preinstalled proprietary gallery app, they use something open-source instead.

I'm getting more and more exhausted by people as I age, I don't know where I still find energy to write replies/explanations to people like you and not just ignore them and pass by, though the latter happens much more often.

Regarding editing, I personally only need cropping, nothing else. As the other commenter said - it's one of the most critical editing features. Rarely I need to draw on images or add text on them (to show something specific to another person) and save them edited. I guess these are two of one of the most needed/most used features by people. It's not normal to download another app simply to crop an image, it's a responsibility of my gallery app. I brought up specifically cropping several times in my comment, because it's probably the simplest editing feature that could be implemented. It seems like most Aves Gallery users use Simple Gallery for basic editing (and due to all that story with Simple Mobile Tools having been acquired, I highly suggest moving to Fossify's Gallery. Fossify forked SMT apps and continues to develop them), and that's what I use too. @opk12 also gave awesome suggestions for editing apps.

[deckerst]

@herrbrixter I personally only need these too. That would be the first features I work on.

By the way, I've recently discovered that the crop features of Snapseed and Google Photos are not as good as I thought (they downgrade the resolution of very large images). So more incentive for me to implement it and do it right.

[idontveapc]

Common editing, like; crop, add text, watermark, (and colour effects) shouldve been added. Still to wait??

I don't use system gallery app, it only lets me crop images. So, rather disabled it.

[zilexa]

Have you considered leveraging libvips for image editing? I am no expert but I believe it's similar but much more advanced and modern compared to ImageMagick.
It may help you implement editor options swiftly and properly without reinventing the wheel.

[deckerst]

Thanks for letting me know.

For the editor in Aves, I need first to decide and implement how it would work (whether it would use layers, undo stack, etc.) and the basic transforms (crop/rotate). Then I would see if/how to integrate with a lib for all the rest.

[zilexa]

Sounds good!