Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error with new django #29

Open
MeggyCal opened this issue Sep 11, 2020 · 0 comments
Open

Error with new django #29

MeggyCal opened this issue Sep 11, 2020 · 0 comments

Comments

@MeggyCal
Copy link

Hi,
while building with Django 3.1 I get the following error:

[   39s] FAIL: test_to_python_not_iso8601 (drf_braces.tests.forms.test_fields.TestISO8601DateTimeField)
[   39s] ----------------------------------------------------------------------
[   39s] Traceback (most recent call last):
[   39s]   File "/home/abuild/rpmbuild/BUILD/django-rest-framework-braces-0.3.4/drf_braces/tests/forms/test_fields.py", line 24, in test_to_python_not_iso8601
[   39s]     field.clean('2015-01-01T16:30')
[   39s] AssertionError: ValidationError not raised

It is clearly related to this change in Django 3.1:

django.forms.DateTimeField now accepts dates in a subset of ISO 8601 datetime formats, including optional timezone, e.g. 2019-10-10T06:47, 2019-10-10T06:47:23+04:00, or 2019-10-10T06:47:23Z. The timezone will always be retained if provided, with timezone-aware datetimes being returned even when USE_TZ is False.

I did not look at the rest of your code, so I do not know whether there are more incompatibilities or not.

Could you please at least try to support Django 3.1? Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant