Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to pass path argument to override project root #16

Merged
merged 1 commit into from
Nov 18, 2021
Merged

Add ability to pass path argument to override project root #16

merged 1 commit into from
Nov 18, 2021

Conversation

ddrscott
Copy link
Owner

#15

@ddrscott
Copy link
Owner Author

@jakutis Took a little while to remember how to Vimscript, but I got it going. The order of the arguments is important, but I don't think I'm breaking any conventions.
With this change, I'm requires the search term to be first and paths to be last. Anything rg or ag can understand can be in the middle.

@ddrscott ddrscott force-pushed the better-path-parsing branch from 9fbd378 to 940abf5 Compare November 17, 2021 16:56
@ddrscott ddrscott mentioned this pull request Nov 17, 2021
Closed
jakutis
jakutis approved these changes Nov 18, 2021
View reviewed changes
Copy link
Contributor

@jakutis jakutis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So awesome, thank you!

@ddrscott ddrscott merged commit ace1038 into master Nov 18, 2021
@ddrscott ddrscott deleted the better-path-parsing branch November 18, 2021 14:57
@jakutis jakutis mentioned this pull request Nov 19, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakutis jakutis jakutis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ddrscott @jakutis