ParserMethods.parse_query - Why sub! and not gsub! parsing filter queries

[homerlex]

In this line of ParserMethods.parse_query:

query_options[:filter_queries] = replace_types([*options[:facets][:browse]].collect{|k| "#{k.sub!(/ *: */,"_facet:")}"}) if options[:facets][:browse]

Why is it k.sub! and not k.gsub! ? Wouldn't we want to replace ALL occurrences of the property names in the string?

If I have an fq of "(property_x:1 OR property_y:1)" then the above code will result in:

"(property_x_facet:1 OR property_y:1)"

What I really want in the end is:

"(property_x_facet:1 OR property_y_facet:1)"

Same question about the line that parses [:facets][:queries]:
query_options[:facets][:queries] = replace_types(options[:facets][:query].collect{|k| "#{k.gsub!(/ *: */,"_t:")}"}) if options[:facets][:query]

[dcrec1]

You're right, in the case you have options[:facets][:query] = ["property_x:1 OR property_y:1"], the query will break.

Can you create a test case and submit a patch?