[Lint] Fix violations of no-var and ban-types
#168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rationale from [1]:
ECMAScript 6 allows programmers to create variables with block scope instead of
function scope using the let and const keywords. Block scope is common in many other
programming languages and helps programmers avoid mistakes such as:
```ts
var count = people.length;
var enoughFood = count > sandwiches.length;
if (enoughFood) {
var count = sandwiches.length; // accidentally overriding the count variable
console.log("We have " + count + " sandwiches for everyone. Plenty for all!");
}
// our count variable is no longer accurate
console.log("We have " + count + " people and " + sandwiches.length + " sandwiches!");
```
[1]: https://eslint.org/docs/latest/rules/no-var
Rationale from [1]: Don't use the upper-case primitive types, you should use the lower-case types for consistency. Don't use `Boolean` as a type. Use `boolean` instead. Fixes 2 linter errors. 99 to go. [1]: https://typescript-eslint.io/rules/ban-types/
|
Your Render PR Server URL is https://flashcards-pr-168.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cpj94oe3e1ms738sbfig. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #162