Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lint] Fix violations of prefer-const #167

Merged
merged 3 commits into from
Jun 10, 2024

Conversation

dchege711
Copy link
Owner

No description provided.

This reverts commit 0710453.

This doesn't work either.
Rationale [1]:

> If a variable is never reassigned, using the `const` declaration is
> better.
>
> `const` declaration tells readers, "this variable is never
> reassigned," reducing cognitive load and improving maintainability.

This change is a candidate for .git-blame-ignore-revs

Fixes 157 of the 281 violations reported by `npm run lint`. 124 more to
go.

[1]: https://eslint.org/docs/latest/rules/prefer-const
Copy link

render bot commented Jun 10, 2024

@dchege711 dchege711 merged commit a3b499b into main Jun 10, 2024
4 checks passed
@dchege711 dchege711 deleted the user/dchege711/fixing-linter-errors-1-of-n branch June 10, 2024 05:00
@dchege711
Copy link
Owner Author

Contributes to #162

dchege711 added a commit that referenced this pull request Jun 11, 2024
Ignore mechanical fixes like:

* #167 `prefer-const`
* #168 `no-var`, `ban-types`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant