-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up CI config and Docker image #122
Conversation
7b2256b
to
6b3d290
Compare
cc1cb81
to
ae26fb3
Compare
@JCZuurmond I'm almost there! Just having issues installing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the struggles with installing dbt-sqlserver
occur because python is installed in the docker image. I think moving the python part out of the docker file should solve this
78dc871
to
2aac2ed
Compare
3ec3222
to
9bef882
Compare
ee6d9ba
to
0e1aa78
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JCZuurmond ok now things are looking much cleaner IMHO. what do you think?
yes, looks good @swanderz! I think it is ready to be merged. There is one change I suggested before, but do not mind too much if not implemented, which I think is nice: use the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
dev_requirements.txt
ordbt-sqlserver
cimg/python:3.7.10
instead ofdocker/python:3.7-slim
as an upstream image.fixes #107