Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Querying dimensions without metrics #804

Merged
merged 15 commits into from
Oct 12, 2023
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Separate test case for invalid group by name
  • Loading branch information
courtneyholcomb committed Oct 12, 2023
commit 61d23c6ea51b332d968d9666495c3c4dd7294706
2 changes: 2 additions & 0 deletions metricflow/test/query/test_query_parser.py
Original file line number Diff line number Diff line change
Expand Up @@ -249,6 +249,8 @@ def test_query_parser_case_insensitivity(bookings_query_parser: MetricFlowQueryP
),
)


def test_query_parser_invalid_group_by(bookings_query_parser: MetricFlowQueryParser) -> None: # noqa: D
with pytest.raises(UnableToSatisfyQueryError):
bookings_query_parser.parse_and_validate_query(group_by_names=["random_stuff"])
courtneyholcomb marked this conversation as resolved.
Show resolved Hide resolved

Expand Down