From d4f77494cadbe8ffd0d50d183dfe51a812fc2c69 Mon Sep 17 00:00:00 2001 From: Courtney Holcomb Date: Mon, 16 Oct 2023 17:52:53 -0700 Subject: [PATCH] Still verify everything except date part --- metricflow/query/query_parser.py | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/metricflow/query/query_parser.py b/metricflow/query/query_parser.py index 7fe1fc7eae..16f3029a74 100644 --- a/metricflow/query/query_parser.py +++ b/metricflow/query/query_parser.py @@ -811,13 +811,20 @@ def _get_invalid_linkable_specs( invalid_linkable_specs.append(entity_spec) for time_dimension_spec in time_dimension_specs: + time_dimension_spec_without_date_part = time_dimension_spec + if time_dimension_spec.date_part: + # TODO: remove line below & add date_part specs to validation paths. + time_dimension_spec_without_date_part = TimeDimensionSpec( + element_name=time_dimension_spec.element_name, + entity_links=time_dimension_spec.entity_links, + time_granularity=time_dimension_spec.time_granularity, + aggregation_state=time_dimension_spec.aggregation_state, + ) if ( - time_dimension_spec not in valid_linkable_specs + time_dimension_spec_without_date_part not in valid_linkable_specs # Because the metric time dimension is a virtual dimension that's not in the model, it won't be included # in valid_linkable_specs. and time_dimension_spec.reference != DataSet.metric_time_dimension_reference() - # TODO: remove line below & add date_part specs to validation paths. - and not time_dimension_spec.date_part ): invalid_linkable_specs.append(time_dimension_spec)