diff --git a/metricflow/dataflow/builder/dataflow_plan_builder.py b/metricflow/dataflow/builder/dataflow_plan_builder.py index 48a13c565c..03cd279649 100644 --- a/metricflow/dataflow/builder/dataflow_plan_builder.py +++ b/metricflow/dataflow/builder/dataflow_plan_builder.py @@ -923,9 +923,10 @@ def _build_aggregated_measures_from_measure_source_node( join_aggregated_measure_to_time_spine = True break - # TODO: if multiple measures and only some join to time spine, should we aggregate separately? # Only join to time spine if metric time was requested in the query. if join_aggregated_measure_to_time_spine and metric_time_dimension_requested: + # TODO: if multiple measures in same node and only some join to time spine, should we split them into + # separate AggregateMeasuresNodes? return JoinToTimeSpineNode( parent_node=aggregate_measures_node, requested_metric_time_dimension_specs=metric_time_dimension_specs,