Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[merge after dec 5th] adds new hard_deletes config #6558

Merged
merged 39 commits into from
Dec 5, 2024

Conversation

@mirnawong1 mirnawong1 requested a review from a team as a code owner November 27, 2024 16:21
Copy link

vercel bot commented Nov 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Dec 5, 2024 10:42am

@github-actions github-actions bot added content Improvements or additions to content size: large This change will more than a week to address and might require more than one person Docs team Authored by the Docs team @dbt Labs labels Nov 27, 2024
| 1 | b1885d098f8bcff53... | shipped | 2024-10-02 ... | 2024-06-03 ... | | False |
| 2 | b1885d098f8bcff55... | active | 2024-10-02 ... | 2024-05-19 ... | | False |

In this example, the `dbt_is_deleted` column is set to `True` when the record is deleted. When the record is restored, the `dbt_is_deleted` column is set to `False`.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would love a gut check if this is right bc I've been reading this over and over again so might have mixed things up.

website/docs/docs/build/snapshots.md Show resolved Hide resolved
website/docs/docs/build/snapshots.md Show resolved Hide resolved
website/docs/docs/build/snapshots.md Show resolved Hide resolved
website/docs/docs/build/snapshots.md Show resolved Hide resolved
website/docs/docs/build/snapshots.md Outdated Show resolved Hide resolved
website/docs/reference/resource-configs/hard-deletes.md Outdated Show resolved Hide resolved
| -- | -------------------- | -------------------- | -------------------- | -------------------- |
| 1 | 60a1f1dbdf899a4dd... | 2024-10-02 ... | 2024-10-02 ... | 2024-10-02 ... |
| 2 | b1885d098f8bcff51... | 2024-10-02 ... | 2024-10-02 ... | |
| id | scd_id | modified_date | start_date | end_date | is_deleted |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same comment as earlier

Copy link
Contributor Author

@mirnawong1 mirnawong1 Nov 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i changed it to the below but also wasn't sure if it made sense to go into hard_deletes:'new_record' detail since this page is about meta column names?

id scd_id modified_date start_date end_date is_deleted
1 60a1f1dbdf899a4dd... 2024-10-02 ... 2024-10-02 ... 2024-10-03 ... False
1 60a1f1dbdf899a4dd... 2024-10-03 ... 2024-10-03 ... True
2 b1885d098f8bcff51... 2024-10-02 ... 2024-10-02 ... False

website/snippets/_hard-deletes.md Outdated Show resolved Hide resolved
mirnawong1 and others added 16 commits November 28, 2024 09:45
@graciegoheen graciegoheen changed the title [merged after dec 5th) adds new hard_deletes config [merged after dec 5th] adds new hard_deletes config Dec 2, 2024
@mirnawong1 mirnawong1 changed the title [merged after dec 5th] adds new hard_deletes config [merge after dec 5th] adds new hard_deletes config Dec 3, 2024
Copy link
Contributor

@dbeatty10 dbeatty10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved overall ✅ Left some non-blocking suggestions.

This is money:

image

And so is this:

image

What do you think about adding a similar table within the "Details for check strategy" toggle?

image

website/docs/docs/build/snapshots.md Outdated Show resolved Hide resolved
website/docs/docs/build/snapshots.md Outdated Show resolved Hide resolved
website/docs/docs/build/snapshots.md Outdated Show resolved Hide resolved
website/docs/docs/dbt-versions/release-notes.md Outdated Show resolved Hide resolved
website/docs/reference/resource-configs/hard-deletes.md Outdated Show resolved Hide resolved
website/docs/reference/resource-configs/hard-deletes.md Outdated Show resolved Hide resolved
website/snippets/_hard-deletes.md Show resolved Hide resolved
website/snippets/_hard-deletes.md Outdated Show resolved Hide resolved
@mirnawong1
Copy link
Contributor Author

mirnawong1 commented Dec 3, 2024

Approved overall ✅ Left some non-blocking suggestions.

This is money:

image And so is this: image What do you think about adding a similar table within the "Details for check strategy" toggle? image

hey @dbeatty10 , woudl this work for the check strategy table example?

Snapshot results with hard_deletes='new_record':

id status dbt_valid_from dbt_valid_to dbt_updated_at dbt_is_deleted
1 pending 2024-01-01 11:00 2024-01-01 11:30 2024-01-01 11:00 False
1 shipped 2024-01-01 11:30 2024-01-01 11:40 2024-01-01 11:30 False
1 deleted 2024-01-01 11:40 2024-01-01 11:40 True

@mirnawong1 mirnawong1 dismissed graciegoheen’s stale review December 5, 2024 10:38

folded in changes and approved by doug

@mirnawong1 mirnawong1 enabled auto-merge December 5, 2024 10:39
@mirnawong1 mirnawong1 merged commit fadcbd3 into current Dec 5, 2024
9 checks passed
@mirnawong1 mirnawong1 deleted the add-hard-deletes-config branch December 5, 2024 10:42
Copy link
Contributor

github-actions bot commented Dec 5, 2024

Check your created Crawler

Check your created index on your Algolia Application

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: large This change will more than a week to address and might require more than one person trigger-crawl
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Core] new_record for hard_deletes config adds is_deleted column to snapshots
3 participants