From 963aa86d43dd40191611bdcbdcd3a6754ae39fef Mon Sep 17 00:00:00 2001
From: tromsky <100031072+tromsky@users.noreply.github.com>
Date: Sat, 2 Sep 2023 11:05:23 -0400
Subject: [PATCH 1/2] Update SL-MF tutorial for proper expr usage and BigQuery

Using an expression in a dimension name is not valid, and the expression is not valid for BigQuery
---
 .../semantic-layer-3-build-semantic-models.md          | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/website/docs/guides/best-practices/how-we-build-our-metrics/semantic-layer-3-build-semantic-models.md b/website/docs/guides/best-practices/how-we-build-our-metrics/semantic-layer-3-build-semantic-models.md
index 2c2122572b8..73fa2363aaf 100644
--- a/website/docs/guides/best-practices/how-we-build-our-metrics/semantic-layer-3-build-semantic-models.md
+++ b/website/docs/guides/best-practices/how-we-build-our-metrics/semantic-layer-3-build-semantic-models.md
@@ -148,7 +148,9 @@ from source
 
 ```YAML
 dimensions:
-      - name: date_trunc('day', ordered_at)
+      - name: ordered_at
+        expr: date_trunc('day', ordered_at)
+        # use date_trunc(ordered_at, DAY) if using BigQuery
         type: time
         type_params:
           time_granularity: day
@@ -166,7 +168,9 @@ We'll discuss an alternate situation, dimensional tables that have static numeri
 ```YAML
 ...
 dimensions:
-  - name: date_trunc('day', ordered_at)
+  - name: ordered_at
+    expr: date_trunc('day', ordered_at)
+    # use date_trunc(ordered_at, DAY) if using BigQuery
     type: time
     type_params:
       time_granularity: day
@@ -254,6 +258,8 @@ semantic_models:
 
     dimensions:
       - name: ordered_at
+        expr: date_trunc('day', ordered_at)
+        # use date_trunc(ordered_at, DAY) if using BigQuery
         type: time
         type_params:
           time_granularity: day

From 32d7fdf6f395178ee42b443c9c3ebb5a490d4691 Mon Sep 17 00:00:00 2001
From: mirnawong1 <89008547+mirnawong1@users.noreply.github.com>
Date: Mon, 11 Sep 2023 12:18:23 +0100
Subject: [PATCH 2/2] Update
 website/docs/guides/best-practices/how-we-build-our-metrics/semantic-layer-3-build-semantic-models.md

---
 .../semantic-layer-3-build-semantic-models.md                   | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/website/docs/guides/best-practices/how-we-build-our-metrics/semantic-layer-3-build-semantic-models.md b/website/docs/guides/best-practices/how-we-build-our-metrics/semantic-layer-3-build-semantic-models.md
index 73fa2363aaf..a2dc55e37ae 100644
--- a/website/docs/guides/best-practices/how-we-build-our-metrics/semantic-layer-3-build-semantic-models.md
+++ b/website/docs/guides/best-practices/how-we-build-our-metrics/semantic-layer-3-build-semantic-models.md
@@ -150,7 +150,7 @@ from source
 dimensions:
       - name: ordered_at
         expr: date_trunc('day', ordered_at)
-        # use date_trunc(ordered_at, DAY) if using BigQuery
+        # use date_trunc(ordered_at, DAY) if using [BigQuery](/docs/build/dimensions#time)
         type: time
         type_params:
           time_granularity: day