Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core] The state directory needs to be built with v1.9+ or Versionless for state_modified_compare_more_unrendered_values #6247

Closed
1 task done
dbeatty10 opened this issue Oct 4, 2024 · 0 comments · Fixed by #6357
Closed
1 task done

[Core] The state directory needs to be built with v1.9+ or Versionless for state_modified_compare_more_unrendered_values #6247

dbeatty10 opened this issue Oct 4, 2024 · 0 comments · Fixed by #6357
Assignees
@matthewshaver
Labels
content Improvements or additions to content dbt-core v1.9 improvement Use this when an area of the docs needs improvement as it's currently unclear

Comments

@dbeatty10
Copy link
Contributor

dbeatty10 commented Oct 4, 2024 •
edited
Loading

Contributions

  • I have read the contribution docs, and understand what's expected of me.

Link to the page on docs.getdbt.com requiring updates

One or more as the same files as https://github.com/dbt-labs/docs.getdbt.com/pull/6239/files

What part(s) of the page would you like to see updated?

In order to avoid this specific cause of false positives, two things need to hold when the state directory is built:

  1. state_modified_compare_more_unrendered_values: true
  2. The v1.9+ or dbt Cloud Versionless

Put another way, the state directory needs to be built with v1.9+ or Versionless along with state_modified_compare_more_unrendered_values: true within dbt_project.yml.

So if the state directory was built with an older version of dbt or if the state_modified_compare_more_unrendered_values behavior change flag was false (or it was not set), it will need to be rebuilt in order to avoid these false positives during state comparison with state:modified.

Additional information

No response
@dbeatty10 dbeatty10 added content Improvements or additions to content improvement Use this when an area of the docs needs improvement as it's currently unclear dbt-core v1.9 labels Oct 4, 2024
@runleonarun runleonarun changed the title The state directory needs to be built with v1.9+ or Versionless for state_modified_compare_more_unrendered_values [Core] The state directory needs to be built with v1.9+ or Versionless for state_modified_compare_more_unrendered_values Oct 15, 2024
@matthewshaver matthewshaver self-assigned this Oct 15, 2024
@matthewshaver matthewshaver mentioned this issue Oct 24, 2024
Merged
4 tasks
runleonarun added a commit that referenced this issue Oct 25, 2024
@matthewshaver @mirnawong1 @runleonarun
Disclaimer on state modified behavior change (#6357)
cb69cf6 
## What are you changing in this pull request and why?

Closes #6247

## Checklist
- [ ] I have reviewed the [Content style
guide](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/content-style-guide.md)
so my content adheres to these guidelines.
- [ ] The topic I'm writing about is for specific dbt version(s) and I
have versioned it according to the [version a whole
page](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/single-sourcing-content.md#adding-a-new-version)
and/or [version a block of
content](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/single-sourcing-content.md#versioning-blocks-of-content)
guidelines.
- [ ] I have added checklist item(s) to this list for anything anything
that needs to happen before this PR is merged, such as "needs technical
review" or "change base branch."
- [ ] The content in this PR requires a dbt release note, so I added one
to the [release notes
page](https://docs.getdbt.com/docs/dbt-versions/dbt-cloud-release-notes).
<!--
PRE-RELEASE VERSION OF dbt (if so, uncomment):
- [ ] Add a note to the prerelease version [Migration
Guide](https://github.com/dbt-labs/docs.getdbt.com/tree/current/website/docs/docs/dbt-versions/core-upgrade)
-->
<!-- 
ADDING OR REMOVING PAGES (if so, uncomment):
- [ ] Add/remove page in `website/sidebars.js`
- [ ] Provide a unique filename for new pages
- [ ] Add an entry for deleted pages in `website/vercel.json`
- [ ] Run link testing locally with `npm run build` to update the links
that point to deleted pages
-->

<!-- vercel-deployment-preview -->
---
🚀 Deployment available! Here are the direct links to the updated files:


-
https://docs-getdbt-com-git-state-comparison-dbt-labs.vercel.app/reference/global-configs/behavior-changes
-
https://docs-getdbt-com-git-state-comparison-dbt-labs.vercel.app/reference/node-selection/state-comparison-caveats

<!-- end-vercel-deployment-preview -->

---------

Co-authored-by: Mirna Wong <[email protected]>
Co-authored-by: Leona B. Campbell <[email protected]>
Co-authored-by: runleonarun <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matthewshaver matthewshaver

Labels
content Improvements or additions to content dbt-core v1.9 improvement Use this when an area of the docs needs improvement as it's currently unclear
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Disclaimer on state modified behavior change dbt-labs/docs.getdbt.com
2 participants
@dbeatty10 @matthewshaver