Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADAP-1018] [Feature] Remove Databricks test profiles from integration tests #937

Closed
3 tasks done
mikealfare opened this issue Nov 7, 2023 · 2 comments
Closed
3 tasks done
Assignees
Labels
enhancement New feature or request Stale triage

Comments

@mikealfare
Copy link
Contributor

Is this your first time submitting a feature request?

  • I have read the expectations for open source contributors
  • I have searched the existing issues, and I could not find an existing issue for this feature
  • I am requesting a straightforward extension of existing dbt-spark functionality, rather than a Big Idea better suited to a discussion

Describe the feature

Given that Databricks users have largely adopted dbt-databricks, we do not need to test these profiles on dbt-spark. Removing these profiles will also result in removing some tests that are only run on these profiles. It is not clear how far back we should implement this change (e.g. is this 1.7+? all supported versions? somewhere in between?)

Describe alternatives you've considered

No response

Who will this benefit?

This will benefit the maintainers as CI run times will be drastically reduced. This will also enable more rapid review and implementation of community PRs, which should deliver more value to our users.

Are you interested in contributing this feature?

Yes

Anything else?

No response

@mikealfare mikealfare added enhancement New feature or request triage labels Nov 7, 2023
@mikealfare mikealfare self-assigned this Nov 7, 2023
@github-actions github-actions bot changed the title [Feature] Remove Databricks test profiles from integration tests [ADAP-1018] [Feature] Remove Databricks test profiles from integration tests Nov 7, 2023
Copy link
Contributor

github-actions bot commented May 6, 2024

This issue has been marked as Stale because it has been open for 180 days with no activity. If you would like the issue to remain open, please comment on the issue or else it will be closed in 7 days.

@github-actions github-actions bot added the Stale label May 6, 2024
Copy link
Contributor

Although we are closing this issue as stale, it's not gone forever. Issues can be reopened if there is renewed community interest. Just add a comment to notify the maintainers.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Stale triage
Projects
None yet
Development

No branches or pull requests

1 participant